Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: add "extra" for IPython, exclude bad IPython release #1151

Merged
merged 5 commits into from
Mar 1, 2022

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Mar 1, 2022

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Towards issue ipython/ipython#13554 encountered in attempt to merge #1150 🦕

@tswast tswast requested a review from a team March 1, 2022 16:29
@tswast tswast requested a review from a team as a code owner March 1, 2022 16:29
@tswast tswast requested a review from shollyman March 1, 2022 16:29
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label Mar 1, 2022
Copy link

@nicain nicain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@shollyman shollyman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like there's future and deprecation warnings still banging out, but LGTM in case you're dealing with those in a subsequent PR.

@tswast
Copy link
Contributor Author

tswast commented Mar 1, 2022

Thanks @shollyman . Filed #1152 to investigate the warnings.

@tswast tswast merged commit 0fbe12d into main Mar 1, 2022
@tswast tswast deleted the tswast-ipython-bad-release branch March 1, 2022 22:03
gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 2, 2022
🤖 I have created a release *beep* *boop*
---


### [2.34.1](v2.34.0...v2.34.1) (2022-03-02)


### Dependencies

* add "extra" for IPython, exclude bad IPython release ([#1151](#1151)) ([0fbe12d](0fbe12d))
* allow pyarrow 7.0 ([#1112](#1112)) ([57f8ea9](57f8ea9))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
…s#1151)

* deps: add "extra" for IPython, exclude bad IPython release

* skip magics tests when IPython not installed

* sort importorskips

* add 3.10 prerelease session

* add continuous session
abdelmegahedgoogle pushed a commit to abdelmegahedgoogle/python-bigquery that referenced this pull request Apr 17, 2023
🤖 I have created a release *beep* *boop*
---


### [2.34.1](googleapis/python-bigquery@v2.34.0...v2.34.1) (2022-03-02)


### Dependencies

* add "extra" for IPython, exclude bad IPython release ([googleapis#1151](googleapis#1151)) ([0fbe12d](googleapis@0fbe12d))
* allow pyarrow 7.0 ([googleapis#1112](googleapis#1112)) ([57f8ea9](googleapis@57f8ea9))

---
This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/python-bigquery API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants